search

mapaction / mapaction-toolbox

A collection of tools to help streamline the process of producing maps including data renaming and map exports.
GNU General Public License v3.0
3 stars 1 forks source link

Cmf descriptor path bug #196

Closed shurst-ma closed 3 years ago

shurst-ma commented 3 years ago

Use hard-coded crash-move-folder JSON file.

andrewphilipsmith commented 3 years ago

@shurst-ma @harry-gibson Did this PR completely or partially close this issue https://github.com/mapaction/mapaction-toolbox/issues/195 ?

harry-gibson commented 3 years ago

@shurst-ma @harry-gibson Did this PR completely or partially close this issue #195 ?

@andrewphilipsmith - Partially. The CMF path is now hardcoded in event_description.json as the value cmf_description.json, so it should work correctly with mapchef and anything else that was broken by the absolute path. However the tool does not yet check that cmf_description.json exists and nor does it provide any functionality for choosing a different file or checking the file contents. I think, but can't prove, that we agreed we'd just do that for the purposes of this release and the rest was nice-to-have.