search

mapbox / leaflet-omnivore

universal format parser for Leaflet & Mapbox.js
https://www.mapbox.com/mapbox.js/example/v1.0.0/omnivore-gpx/
Other
651 stars 126 forks source link

IE9 Support #42

Closed lulis closed 8 years ago

lulis commented 10 years ago

Hi, On CHANGELOG omnivore seems to support IE9. But if you try to open any of the Mapbox Omnivore samples (like https://www.mapbox.com/mapbox.js/example/v1.0.0/omnivore-kml/) on IE9, page will hang an browser will say that "mapbox.com is not responding".

Trying on home, i got the message "No such interface supported" on JS console. Char 29 on this line: https://github.com/mapbox/leaflet-omnivore/blob/v0.3.0/leaflet-omnivore.js#L786

I'm testing on the IE 9/Win 7 virtualbox image from modern.IE Hope that you can fix it, there is a lot of people still using IE9...

Thanks.

tmcw commented 10 years ago

This is an open source project: if this matters to you, and you want to see it fixed, the most expedient way is to do it yourself and submit a pull request. At the moment I don't have enough time to test this module thoroughly in IE9.

lulis commented 10 years ago

Sorry, Tom, I'm really a newbie on GH.

Besides that, I've fixed it (to my own use) replacing the referred line by: function xml2str(str) { return str.xml || serializer.serializeToString(str); }

Hope that it can helps and maybe you can put this fix on next version. Have a nice day!

tmcw commented 8 years ago

Closing; happy to accept a pull request implementing this change, otherwise IE9 is not a high maintainer concern.