search

mapbox / mapbox-maps-ios

Interactive, thoroughly customizable maps for iOS powered by vector tiles and Metal
https://www.mapbox.com/mapbox-mobile-sdk
Other
468 stars 152 forks source link

[GestureSettings] Align the name between Android and iOS #2211

Open tuyen-vuduc opened 2 months ago

tuyen-vuduc commented 2 months ago

Environment

Observed behavior and steps to reproduce

The common properties' names of GestureSettings on iOS are different from the one in Android.

Expected behavior

The common properties's name of GestureSettings should be the same for both platforms

Notes / preliminary analysis

Is this the right mapping?

# Android iOS Aligned
1 rotateEnabled rotateEnabled YES
2 scrollEnabled panEnabled NOPE
3 scrollMode panMode NOPE
4 simultaneousRotateAndPinchToZoomEnabled simultaneousRotateAndPinchZoomEnabled NOPE
5 doubleTouchToZoomOutEnabled doubleTouchToZoomOutEnabled YES
6 doubleTapToZoomInEnabled doubleTapToZoomInEnabled YES
7 focalPoint focalPoint YES
8 pitchEnabled pitchEnabled YES
9 quickZoomEnabled quickZoomEnabled YES
10 pinchScrollEnabled pinchScrollEnabled YES
11 pinchToZoomEnabled N/A NOPE
12 pinchToZoomDecelerationEnabled N/A NOPE
13 rotateDecelerationEnabled N/A NOPE
14 scrollDecelerationEnabled N/A NOPE
15 increaseRotateThresholdWhenPinchingToZoom N/A NOPE
16 increasePinchToZoomThresholdWhenRotating N/A NOPE
17 zoomAnimationAmount N/A NOPE
18 N/A pinchEnabled NOPE
19 N/A pinchZoomEnabled NOPE
20 N/A panDecelerationFactor NOPE

Am I right that (Android)pinchToZoomEnabled = (iOS)PinchEnabled & PinchZoomEnabled?

Additional links and references

N/A

pjleonard37 commented 2 months ago

Thanks for sharing this report @tuyen-vuduc. I'll take this back to the team for discussion.