Replace voice ID option with language option

mapbox / mapbox-speech-swift

Natural-sounding text-to-speech in Swift or Objective-C on iOS, macOS, tvOS, and watchOS

ISC License

43 stars 17 forks source link

Replace voice ID option with language option #2

Closed 1ec5 closed 6 years ago

1ec5 commented 7 years ago

The voiceId option couples this library too closely to the AWS SDK. I think instead the API should accept a language parameter, and we can map the language to our preferred Polly voice on the server side. The locale option in this library would default to the system locale, just as it does in MapboxDirections.swift.

/cc @bsudekum

bsudekum commented 6 years ago

Hit here https://github.com/mapbox/mapbox-voice-swift/blob/e592a50ee7af568cc64722565fdd5dc80030bc91/MapboxSpeech/MBSpeechOptions.swift#L151

Once https://github.com/mapbox/api-voice/pull/14 is deployed, we'll be good to go.