mapbox / mapbox-speech-swift

Natural-sounding text-to-speech in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
ISC License
43 stars 17 forks source link

Allow overriding SpeechOptions URL query parameters #50

Open 1ec5 opened 2 years ago

1ec5 commented 2 years ago

SpeechOptions.path and SpeechOptions.params are internal. We should rename them to abridgedPath and urlQueryItems, respectively, and make them open, for consistency with RouteOptions in MapboxDirections. This will enable developers to pass in additional settings that aren’t supported by this library, such as beta parameters that it can’t support due to backwards compatibility concerns.

https://github.com/mapbox/mapbox-speech-swift/blob/b0a6008c184c1010dac11e14bf20afe4261d8c36/Sources/MapboxSpeech/MBSpeechOptions.swift#L65 https://github.com/mapbox/mapbox-speech-swift/blob/b0a6008c184c1010dac11e14bf20afe4261d8c36/Sources/MapboxSpeech/MBSpeechOptions.swift#L74

/ref mapbox/mapbox-directions-swift#343 mapbox/mapbox-directions-swift#461 /cc @mapbox/navigation-ios @browndp08 @Guardiola31337