Remove redundant copy-assignment

mapbox / variant

C++11/C++14 Variant

BSD 3-Clause "New" or "Revised" License

371 stars 100 forks source link

Remove redundant copy-assignment #94

Closed dippi closed 8 years ago

dippi commented 8 years ago

The first definition of conversion assignment uses universal reference and forwarding and (IMHO) there's no need for an additional operator that only matches const references. (And by the way the second definition used to copy-construct the object twice)

dippi commented 8 years ago

Not sure why it failed to build only with xcode6.

Besides that, I think it needs some adjustments on the noexcept specifier.

dippi commented 8 years ago

Which brings me to issue #88, so the problem was known and the proposed solution is actually better. Looking forward to see those changes applied. B.R.