Implement Mapbox.Geometry

mapbox / vector-tile-cs

Parses vector tiles with C#.

BSD 3-Clause "New" or "Revised" License

57 stars 37 forks source link

Implement Mapbox.Geometry #18

Open wilhelmberg opened 8 years ago

wilhelmberg commented 8 years ago

/cc @mapbox/games

Carrying over @springmeyer's comments from https://github.com/mapbox/vector-tile-cs/issues/7#issuecomment-260404842

Pass only a scaling value to decode geometries into tile coordinates: https://github.com/mapbox/vector-tile/blob/050da15c2af0e5b4c0b6459c4ebb61172b89e2a3/include/mapbox/vector_tile.hpp#L209

As far as geometry storage, ignore my flat array comment - we do want easy to use, nested, arrays for parts following the lead of https://github.com/mapbox/geometry.hpp.

I've started the C# counterpart of geometry.hpp here: https://github.com/mapbox/GeometryCs

But we won't follow the C++ lead until geometry.hpp has fully found its way into vector_tile.hpp

tmpsantos commented 8 years ago

:+1:

david-rhodes commented 7 years ago

@brnkhy Did you see this?

Pass only a scaling value to decode geometries into tile coordinates

This sounds relevant to your recent optimizations.

@BergWerkGIS Was this specific piece implemented? Is this similar to what @brnkhy is doing here: https://github.com/mapbox/mapbox-unity-sdk/tree/vector2d?

brnkhy commented 7 years ago

@david-rhodes that's actually what I'm doing as well (scaling parameter thing). Vector tile coordinate system is a little different, I initially thought we have the commands to calculate the geometry which would have taken much longer. Then realized that's actually already done and we have vector tile coordinates which I can simply scale to our tiles etc.

wilhelmberg commented 7 years ago

@david-rhodes @brnkhy The scale parameter exists in the method signature but currently it's not implemented.

wilhelmberg commented 7 years ago

REMOVED comment! created a new issue dedicated to discussion about scale: #30