mapeditor / tiled

Flexible level editor
https://www.mapeditor.org/
Other
11.3k stars 1.76k forks source link

Update Python plugin API to support new features #1833

Open bjorn opened 6 years ago

bjorn commented 6 years ago

List of missing features:

(likely incomplete)

ilanosortap commented 6 years ago

I want to work on this task, can you tell me what needs to be done exactly?

bjorn commented 6 years ago

Check out src/plugins/python/tiledbinding.py for the current script API bindings and extend it so that scripts can access and modify the classes and properties related to the features listed above. Install pybindgen to be able to update the resulting pythonbind.cpp file.

The list is not necessarily complete, so part of the task would also be to check if all features are covered (for example, by comparing the TMX map format to the bindings to see if all data types and attributes are covered.

Any help would anyway be very appreciated, so you can start with a small step and go on from there.

ilanosortap commented 6 years ago

I have made the changes, can you let me know which branch to push the changes to?

bjorn commented 6 years ago

@ilanosortap Currently the only relevant branch is the master branch, since 1.1 did not yet get its own branch. When there would be a 1.1 branch, your changes should probably go there, provided they do not break API compatibility.

ilanosortap commented 6 years ago

tiled I am getting this error, can you help me out?

bjorn commented 6 years ago

@ilanosortap Hmm, I don't see anything strange about your master branch on GitHub that could cause this. There are no new commits on it, and it's simply 80 commits behind my master branch, but that should not cause this problem. Can you give the first couple of lines of git log --online for your local repository?

bjorn commented 6 years ago

@ilanosortap Note that in the meantime I have created a 1.1 branch and your pull request should likely target that branch, provided it keeps compatibility.

bjorn commented 6 years ago

I made the push, but i am not able to add the pull request

What does that mean? What problem are you encountering? Also, in your fork I do not see new commits, so I think something must have gone wrong with the push still.

bjorn commented 6 years ago

@ilanosortap Ah, I see you've pushed commits to a 1.1 branch in your fork. However, you've set up your 1.1 branch to be entirely different from my 1.1 branch. You somehow managed to have only two commits in your branch, rather than two commits on top of my 1.1 branch: https://github.com/ilanosortap/tiled/commits/1.1

I would suggest you name this branch something else, then create a new 1.1 branch based on mine and commit your changes on top of that.

ilanosortap commented 6 years ago

I have made the pull request on the 1.1 branch (#1861)

yashgandhe666 commented 6 years ago

Have added support for methods of map.h and tileset.h (#1867)