search

mapkibera / target

QA for OSM data
1 stars 0 forks source link

Develop QA for Mathare #2

Open muindre opened 5 years ago

muindre commented 5 years ago

https://docs.google.com/spreadsheets/d/1r8NinJojSo7nQy6mD8YSNB5fF4gFLIyQscVhMs5rZpA/edit#gid=0

mikelmaron commented 5 years ago

@muindre getting a chance to look at this.

First, I updated https://mapkibera.github.io/target/mathare/ with the latest Mathare data from OSM, and the previous QA structure.

Am I to understand that we should resolve all the questions and comments in this spreadsheet and then when settled, I apply it to the QA config for https://mapkibera.github.io/target/mathare/, on the same Mathare data from OSM?

In the spreadsheet, can you remind me about the meaning of the Better tag column, in green? I'm confused between that and comments on the Change to column.

muindre commented 5 years ago

"Am I to understand that we should resolve all the questions and comments in this spreadsheet and then when settled, I apply it to the QA config for https://mapkibera.github.io/target/mathare/, on the same Mathare data from OSM?" Yes. that's the plan. I have already responded to the comments that you left yesterday.

muindre commented 5 years ago

"First, I updated https://mapkibera.github.io/target/mathare/ with the latest Mathare data from OSM, and the previous QA structure."

Quick one, does the data have to be on OSM already in order to apply to the QA config. The files-mathare data- that I sent you, we have not yet uploaded to OSM. How did you with the previous test run?

mikelmaron commented 5 years ago

I have already responded to the comments that you left yesterday.

Thanks I'll take a look

How did you with the previous test run?

It looks like you provided OSM XML and I worked with that. This is the current data you have in staging, correct? I'd have to write something to convert the CSV, possible. If you have as OSM XML, can make it even faster.

mikelmaron commented 5 years ago

@muindre I have updated https://mapkibera.github.io/target/mathare/ with the data you provided in the spreadsheet. Some of the QA checks have been updated per the Tag list sheet, but sorry I have not had time to do all of them. Please work as much as possible from what you have here, and I'll update again in a week once I'm back.

muindre commented 5 years ago

It looks like you provided OSM XML and I worked with that. This is the current data you have in staging, correct? I'd have to write something to convert the CSV, possible. If you have as OSM XML, can make it even faster.

Sorry I missed this part. Yes that is the data that we were editing but it still had somethings to fix like changing the 'Ys' to match the correct response.

The data that should have been used is this https://mapkiberatrust.slack.com/archives/CD5F98V2N/p1555323566005100