search

maplibre / maplibre-style-spec

MapLibre Style Specification & Utilities
https://maplibre.org/maplibre-style-spec/
Other
94 stars 66 forks source link

Move types, clean imports, move interpolate method #903

Closed HarelM closed 2 weeks ago

HarelM commented 2 weeks ago

Launch Checklist

This PR is mainly a refactoring of exiting code. There were some classes that were placed in utils instead of types folder. I moved the code around to fix that. Also removed the deprecated interpolation factory. I moved the imports to be at the begging of the file where I saw that this was not the case.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.64706% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (89713fd) to head (7efa923). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/expression/types/color.ts 84.84% 5 Missing :warning:
src/expression/definitions/interpolate.ts 77.77% 4 Missing :warning:
src/expression/index.ts 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #903 +/- ## ========================================== + Coverage 92.73% 92.79% +0.05% ========================================== Files 105 105 Lines 4683 4689 +6 Branches 1323 1323 ========================================== + Hits 4343 4351 +8 + Misses 340 338 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 2 weeks ago

@birkskyum I believe you are familiar with most of the code changes here. Let me know if something here is not clear.