mapsme / omim

🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android
Apache License 2.0
4.57k stars 1.15k forks source link

The app always desperately wants location access #7183

Open thany opened 6 years ago

thany commented 6 years ago

I've denied the app location access, because it always desperately wants to pan to my current location. That in itself, is absolutely awful behaviour and must be fixed.

Regardless, the app pops up a dialog asking the user to enable location access, or stop looking. No matter how often I tap the Stop button, the dialog keeps coming back.

This app is way too persistent and desperate in wanting the user's current location.

burivuh commented 6 years ago

Hi!

Does this popup is shown again after an app is restarted (you can detect it if you see a splash screen even on switching back)?

thany commented 6 years ago

Yes. It repeatedly comes back.

jancborchardt commented 6 years ago

Can confirm, the popup shows again every time. (As also reported in my duplicate https://github.com/mapsme/omim/issues/7223)

thany commented 6 years ago

Can someone explain why this issue won't get fixed?

jancborchardt commented 6 years ago

cc @rokuz @Zverik this basically seems like a bug, as I don't assume you expect everyone to have GPS on always, or do it in such a blocking way?

thany commented 6 years ago

I have explicitly revoked GPS access for the app, because otherwise it will "fly" back to my current location. I don't want that. Ever.

jaller94 commented 6 years ago

This has been addressed before: #5298. I guess the location enforcement is part of their product specification. It seems like they want to max out the amount of users sharing their location, regardless of some getting frustrated/ churning because they don't want to.

It would be great to have an official statement on this.

thany commented 6 years ago

It's been addressed, but I frankly don't care. The more issues about this problem, the better. It indicated urgency. This problem is so fantastically easy to solve, it's literally a 5 or 10 minute fix. And yet, it's been taking well over a year to get it sorted.

While this immensely annoying problem exists, at the same time they keep adding commerical and online-only crap to the app. Apparently, they are digging their own grave by destroying its usefulness if this goes on any longer.

jancborchardt commented 6 years ago

@thany all things considered, please keep in mind everyone is human and let's make sure to have civil communication.

thany commented 6 years ago

@jancborchardt I'll repeat myself: this problem has been muddling along for well over a year, while it should take less than 10 minutes to fix. From that perspective, I think it's perfectly valid to become a little bit upset, don't you think?

jaller94 commented 6 years ago

@thany The product belongs to the company Maps.me and in the end it's their decision of what to put in and leave out. This is a public conversation and should on based on reason (preference, privacy concerns, accessibility and more) rather than emotions. (I don't think we're there yet though.) You could directly contact their support, gather supporters for the feature, submit a PR, start a fork or hire somebody to do so.

thany commented 6 years ago

Well, I mean it's a bug they introduced, which is provable by installing a pre-6.0-ish version of the app, iirc. So objectively speaking, this is purely a regression, and should not need to involve "gathering support" to get towards a fix. Should just simply get fixed by the same team who broke it.

jancborchardt commented 6 years ago

@thany as a contributor to several open source projects myself, I can assure you that getting upset and writing a lot of comments on issues will not help get them fixed quicker but more likely do the exact opposite. Remember you are getting this product as fully free & open source and it’s a pretty great app at that.

thany commented 6 years ago

I paid for MapsWithMe Pro, so "fully free" isn't true. Also it's been getting worse, as I stated.

Anyway, nothing saying anything also won't get the problem fixed. We live in a world where, if you break something, you are responsible for getting it fixed. This is exactly what a regression is. So I just don't understand why the team refuses to fix it.

thany commented 6 years ago

Devs, please fix this issue. I consider this a severe usability issue. No matter how it's explained from a positive angle, it's still a bug and it's still unsolved.

fieldmanual2 commented 5 years ago

Yes please, this feature is hell annoying, let me try to explain - when you are on a bicycle trip with tent (so no hotels, wifi/lte anything like that) in a country new to you, you try to preserve battery as much as u can, so my phone usually full save mode, gps only mode, and every time i unlock the screen to see where i am - BAM! - the app pops up a dialog asking the user to enable location access, imaging pushing the cancel/stop button when u r on bicycle down a mountain serpantine going full speed with cars and motorcycles passing by! Please, make this an option (on/off)!!

thany commented 5 years ago

This is why I keep advocating making the location button tristate again, as it used to be years ago, which worked absolutely perfect. Some nobbin at MAPS.ME thought it was a good idea to destroy perfectly well functioning stuff and replace it by annoying guff that doesn't work.

So tristate means: Default = whatever it was before the app closed last (which means just to always remember it) State 1 = Do not follow current location (and don't attempt to find current position at all) State 2 = Follow current location (until map is moved manually, then go to state 1) State 3 = Follow current location and direction (until map is moved manually, then go to state 1)

When the app STARTS (so not when switching to it, which means only when the app was deliberately exited / backed out of) it might go to state 2, just like Google Maps. Or you add an option for it. Or just remember what the user has chosen.

Actually, this is almost the Google Maps behaviour as far as the location button goes. You'd think Google has got it nailed.

WPFilmmaker commented 4 years ago

+1! As October 2019 on Android 7.0 maps 9.1.8-8 from F-Droid the issue still persist.

thany commented 4 years ago

Yes, it's frankly disgusting to leave such an annoying bug in the app.

If you allow location, it'll fly to your current location, even if you're working on bookmarks for your upcoming overseas holiday. Deeply, deeply annoying. I you disallow location access, it'll popup a question asking to continue looking for location, or to stop. And that will happen at any random point in time. Also, quite annoying.

So fix number one: Make it NOT fly to my current location if I explicitly told it not to!

Fix number two: If location access is denied, don't ask for it anyway! No means no!