search

mar-file-system / GUFI

Grand Unified File-Index
Other
46 stars 23 forks source link

Pdflatex check #144

Closed johnbent closed 1 year ago

johnbent commented 1 year ago

I was passing -DLATEX_BUILD=On but it was silently failing to make the pdfs because pdflatex wasn't installed. So this kills the cmake if the user passed -DLATEX_BUILD=On and doesnt have pdflatex installed.

johnbent commented 1 year ago

Sorry, one sec. This somehow contains a bunch of changes I do not want to include in this PR. Please don't review it yet. Let me try to clean it up. Sorry about that!

johnbent commented 1 year ago

Sorry, one sec. This somehow contains a bunch of changes I do not want to include in this PR. Please don't review it yet. Let me try to clean it up. Sorry about that!

Cleaned it up. Ready for review!

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (e76c362) 91.34% compared to head (3d9b3b7) 91.33%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #144 +/- ## ========================================== - Coverage 91.34% 91.33% -0.02% ========================================== Files 58 58 Lines 6542 6542 Branches 745 745 ========================================== - Hits 5976 5975 -1 Misses 367 367 - Partials 199 200 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/mar-file-system/GUFI/pull/144/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.