search

marcan / blitzloop

Open source karaoke software
GNU General Public License v2.0
207 stars 31 forks source link

Reference to record.py should be removed from INSTALL.md #47

Open jose1711 opened 4 years ago

jose1711 commented 4 years ago

This line in INSTALL.md should be updated as record.py is no more

ffms (optional, for record.py)
jose1711 commented 4 years ago

Thank you. ffmsvideo.py still contains reference to ffms (even though it does not seem to be imported):

$ grep -r ffms
blitzloop/ffmsvideo.py:import ffms
blitzloop/ffmsvideo.py:        self.vsource = ffms.VideoSource(song.videofile)
blitzloop/ffmsvideo.py:        self.vsource.set_output_format([ffms.get_pix_fmt("bgr32")])

Maybe this could get removed too to make it clean.

marcan commented 4 years ago

Yup, that file needs to go. Reopening so I remember to do it (I'm not home now)