search

marcelklehr / vdom-virtualize

Virtualize a DOM node
MIT License
131 stars 27 forks source link

Issue with Browserify bundle #40

Closed optimalisatie closed 8 years ago

optimalisatie commented 8 years ago

Hi!

I found a JSPerf test from 2015 that is using your library to test the performance of Virtual-Dom however it appears that there is a problem with the browserified bundle of vdom-virtualize.

https://wzrd.in/bundle/vdom-virtualize@latest https://wzrd.in/standalone/vdom-virtualize@latest

---FLAGRANT SYSTEM ERROR---

(logs uuid: 44b82b80-c401-11e5-ab1a-5789981fbb2a )

Error: "npm exited with code 1"

code: 1
stdout: 
stderr: npm ERR! Linux 3.8.0-19-generic
npm ERR! argv "node" "/home/admin/browserify-cdn/node_modules/.bin/npm" "install" "--production" "--registry" "http://registry.npmjs.org/"
npm ERR! node v0.10.26
npm ERR! npm  v2.14.15

npm ERR! Cannot read property 'virtual-dom' of undefined
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/vdom-virtualize116026-18761-sgvwxu/node_modules/vdom-virtualize/npm-debug.log

dirPath: /tmp/vdom-virtualize116026-18761-sgvwxu

This is probably an issue with the package, and not browserify-cdn itself.
If you feel differently, feel free to file a bug report at:

    https://github.com/jfhbrook/browserify-cdn/issues

Include the ENTIRETY of the contents of this message, and the maintainer(s)
can try to help you out.

Have a nice day!
marcelklehr commented 8 years ago

This seems to be an npm bug. See https://github.com/npm/npm/issues/6581

marcelklehr commented 8 years ago

Fixed. See https://wzrd.in/standalone/vdom-virtualize@1.0.4

optimalisatie commented 8 years ago

Thanks a lot! The JSPerf test is working again.

http://jsperf.com/replacement-v-diffpatching/10