replacing deprecated methods per analyzer warning notes

marcoarment / BugshotKit

iOS in-app bug reporting for developers and testers, with annotated screenshots and the console log.

MIT License

1.36k stars 138 forks source link

replacing deprecated methods per analyzer warning notes #38

Open rcarlsen opened 10 years ago

rcarlsen commented 10 years ago

The static analyzer was complaining about aslresponse_next() and aslresponse_free(); the deprecation comments point out appropriate replacements, which I've substituted here.

rcarlsen commented 10 years ago

It appears that the Apple header incorrectly describes asl_next() and asl_release() being available in iOS 7.0. They are not defined in the 7.0 SDK header (/usr/include/asl.h).

I'll update this PR with an additional compile and run-time check.

rcarlsen commented 10 years ago

I've reverted to the deprecated methods but silence the warning, along with a lengthy comment about the issue to alert the future us' about why it was done.