search

marcopompili / django-instagram

Instagram application for Django.
BSD 3-Clause "New" or "Revised" License
76 stars 27 forks source link

Update name for templatetags library #29

Closed fsouza closed 4 years ago

fsouza commented 4 years ago

This fixes compatibility with Django 3, by using static instead of staticfiles.

Closes #28.

marcopompili commented 4 years ago

Thanks for the PR, but by doing this it means dropping support to versions prior to 3, I already fixed this problem by doing a version check, still I haven't pushed the commit.

fsouza commented 4 years ago

Not sure what you mean. load static was introduced in 1.10 I think (and Django 1 has reached end of life).

Do you need to support versions older than that?

marcopompili commented 4 years ago

Oh I thought this also involved Django 2, good to know. ATM minimum version requirement is Django >= 1.6, gonna set this to 1.11 and avoid staticfiles completely.

fsouza commented 4 years ago

@marcopompili can you push 0.3.2 to pypi?

Thank you very much for your work! 😁

marcopompili commented 4 years ago

It should be out on pypi, just pushed