margelo / react-native-graph

📈 Beautiful, high-performance Graphs and Charts for React Native built with Skia

https://margelo.io

MIT License

2.04k stars 115 forks source link

feat: ability to customize SelectionDot component #35

Closed robinvw1 closed 2 years ago

robinvw1 commented 2 years ago

Description

The current selection dot is 'design-wise' quite opinionated. It has a light shadow and an outer ring.

Instead of introducing a lot of new props (no offence https://github.com/margelo/react-native-graph/pull/21) to customize the look-and-feel of the selection dot, I went for a flexible way to provide your own SelectionDot component.

Demo

Default situation	With custom selection dot

mrousavy commented 2 years ago

LGTM thank you!