margelo / react-native-graph

📈 Beautiful, high-performance Graphs and Charts for React Native built with Skia
https://margelo.io
MIT License
2.04k stars 115 forks source link

feat: pan gesture timeout configurable by prop #43

Closed Nodonisko closed 1 year ago

Nodonisko commented 1 year ago

This add option to configure timeout before pan gesture start. This could be very useful especially if you want to disable timeout.

Motivation: Most of our users was confused with hold timeout and never find out there is something like pan gesture without directly telling them, that they should hold before it starts. Also this behavior without hold timeout is very similar to other apps with same type of graph like Revolut or Kraken app.

juriczech commented 1 year ago

Any update on this? I find the timeout to be a bit of a bottleneck on my app as well.

chrispader commented 1 year ago

LGTM! 🚀 Thanks for your help @Nodonisko