search

marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.69k stars 129 forks source link

Emacs code as separate project #24

Closed semperos closed 13 years ago

semperos commented 13 years ago

To begin, excellent work!

I think it would be beneficial to separate the midje-mode and other Emacs code into a separate project. This would allow folks to git clone your Emacs work and keep up-to-date with that, without cluttering local folders dedicated to Emacs code with the rest of Midje's source.

marick commented 13 years ago

I have no opinion. Others?

ghost commented 13 years ago

Agree with semperos

tcrayford commented 13 years ago

Agree

marick commented 13 years ago

OK. I'm in Europe for until mid-June, so don't expect anything soon. Feel free to submit a pull request.

semperos commented 13 years ago

marick - Take your time and enjoy Europe. We can't really do a pull request, because you need to setup a new Github repo for your midje-mode elisp code and push it up. Once you've done that and put the code in it, we can issue a pull request that deletes the code from this repo :)

-Daniel

ghost commented 13 years ago

Hi!

I've created separated repo for the midje-mode and pushed some commits there. You can browse it here: https://github.com/dnaumov/midje-mode/commits/master. Also you can find recipe for el-get here: https://github.com/dnaumov/el-get/blob/master/recipes/midje-mode.el. I haven't done pull reuqest to el-get yet, because you may want to create repo for midje-mode under your account.

marick commented 13 years ago

See https://github.com/dnaumov/midje-mode

semperos commented 13 years ago

@dnaumov Alrighty, now you just have to keep up-to-date with marick's code ;)

Thanks for at least entertaining the idea, @marick.

-Daniel

marick commented 13 years ago

"Entertaining the idea"? Was there something more I should have done that I didn't?

semperos commented 13 years ago

Didn't mean that in an accusatory way, and perhaps I misunderstand the relationship with dnaumov's repo. I understood the current solution to be: dnaumov will house your emacs code in his separate midje-mode repo, which he'll have to keep in sync with your code manually.

If, however, dnaumov is taking over development of midje-mode, or you're going to be a contributor to his separate repo, then I've misunderstood the solution. Either way, I'm excited its been separated out and look forward to more of your excellent work.

marick commented 13 years ago

I think dnaumov knows modern emacs better than I do, so I'm happy to appoint him the Keeper of Midje-Mode, with me as either a committer or someone who sends pull requests. (I haven't made any changes in a long time.) I'd assumed that was what he wanted (or was willing to accept). But maybe I should have asked! (<-- novel concept!)

On Jun 22, 2011, at 5:07 PM, semperos wrote:

Didn't mean that in an accusatory way, and perhaps I misunderstand the relationship with dnaumov's repo. I understood the current solution to be: dnaumov will house your emacs code in his separate midje-mode repo, which he'll have to keep in sync with your code manually.

If, however, dnaumov is taking over development of midje-mode, or you're going to be a contributor to his separate repo, then I've misunderstood the solution. Either way, I'm excited its been separated out and look forward to more of your excellent work.

Reply to this email directly or view it on GitHub: https://github.com/marick/Midje/issues/24#issuecomment-1421507

Brian Marick, Artisanal Labrador Contract programming in Ruby and Clojure Occasional consulting on Agile www.exampler.com, www.twitter.com/marick

semperos commented 13 years ago

That all makes complete sense. Thanks again for all your hard work!