marijnh / Eloquent-JavaScript

The sources for the Eloquent JavaScript book
https://eloquentjavascript.net
3.01k stars 793 forks source link

Use Ctrl-Down as close editor shortcut #450

Closed estan closed 6 years ago

estan commented 6 years ago

@marijnh Going through your great book (thanks!).

This PR changes to Ctrl-' Ctrl-Down instead of Ctrl-` as the keyboard shortcut for leaving the editor in the examples, since many non-US keyboards do not have a backtick key, making it's impossible to enter the shortcut. For example my Swedish keyboard has none, and the only way to enter a backtick is as a diacritic for space (Shift-' followed by Space).

Hope that's OK. Let me know if another shortcut is more appropriate.

marijnh commented 6 years ago

Oh, right, that's awkward. Would Ctrl-Down also work for you? That's probably easier to read and understand.

estan commented 6 years ago

@marijnh Good idea, changed to Ctrl-Down (yes I do have a Down key :) )

marijnh commented 6 years ago

Thanks! Merged.

estan commented 6 years ago

@marijnh BTW how often do you update the copy at http://eloquentjavascript.net/ ? I could use this advanced Ctrl-Down functionality right about now :)

marijnh commented 6 years ago

Should be updated now!