marijnh / Eloquent-JavaScript

The sources for the Eloquent JavaScript book
https://eloquentjavascript.net
3.01k stars 793 forks source link

Chapter 21 Skillsharing comments don't work in Safari #480

Closed jefflovejapan closed 5 years ago

jefflovejapan commented 5 years ago

I've tried running the skillsharing sample code for Chapter 21 (as well as working through it in the book) and it seems that the comment paragraphs are resolving to a display value of none, hiding them from the page in Safari 12.1. The issue does not appear in Chrome.

I've tried manually editing skillsharing.css to add display: block but it doesn't seem to make a difference. I'm new to HTML and CSS so can't figure out why it would work in Chrome and not Safari.

Screen Shot 2019-05-20 at 10 19 24 PM
karbassi commented 5 years ago

@jefflovejapan it looks like you may have a Safari extension/addon that has added a display: none; to the comment class.

Notice that "user stylesheet".

58061664-85437680-7b4d-11e9-807d-002193b4f0fa

Disable all extensions and try it again.

jefflovejapan commented 5 years ago

That's totally the problem. Thanks for the help.