search

marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.
https://marimo.io
Apache License 2.0
6.66k stars 232 forks source link

Ctrl-[ does not act as Escape in vim mode #558

Open inducer opened 8 months ago

inducer commented 8 months ago

Describe the bug

Somehow, I've trained myself to use Ctrl-[ as escape in vim and vim-likes (much closer to the home row than the actual Escape key, given that I have Caps mapped to Ctrl). As you may be able to guess, this throws a bit of a wrench in my muscle memory. This seems like a hopefully easy thing to fix that would make Marimo easier to adopt for me. As additional context, this was on Firefox in Linux. I have Vimium (a browser extension for more Vim-like browsing) installed, but I did turn it off for Marimo. Other web pages seem to be able to capture Ctrl-[ just fine.

Environment

{ "marimo": "0.1.76", "OS": "Linux", "OS Version": "6.5.0-5-amd64", "Processor": "", "Python Version": "3.12.1", "Binaries": { "Chrome": "--", "Node": "v18.19.0" }, "Requirements": { "black": "23.9.1", "click": "8.1.7", "jedi": "0.19.1", "pymdown-extensions": "10.7", "tomlkit": "0.12.1", "tornado": "6.3.3", "typing_extensions": "4.8.0" }

Code to reproduce

(none)

akshayka commented 8 months ago

Thanks for reporting. I think I would have noticed this too, had I not recently remapped caps lock to escape on my keyboards. We'll look into a fix.

mscolnick commented 8 months ago

@inducer - seems like part of your issue got stripped

image
mscolnick commented 8 months ago

also, fwiw, I cannot produce this on Mac/Chrome, so likely an OS issue with Linux

inducer commented 8 months ago

seems like part of your issue got stripped

Thanks! Edited. Not sure where it went, I distinctly remember typing the rest of it... :shrug:

akshayka commented 8 months ago

I can reproduce it on Linux/Chrome. I will look into it