Adding Portuguese language

mariokreitz / pokedex-v2

A project focused on implementing and showcasing the PokeAPI v2, providing a comprehensive and interactive platform for exploring Pokémon data, including species, abilities, moves, and more.

https://pokedex.mario-kreitz.dev/

MIT License

2 stars 1 forks source link

Adding Portuguese language #6

Closed ferracioli closed 1 month ago

ferracioli commented 1 month ago

Hello, I am just opening this issue in order to update my status with the page translation. I managed to swap the angullar ternary interpolations for dictionaries(like in the image below) in order to allow multiple languages.

My progress is around 60% of page translation, and I will take some extra time to finish it. The future mapped challenges are:

Style the language selector(it changed from switch to a select tag)
Check if the PokeAPI has the portuguese language option(we brazilians never have titles with portuguese as official language :( )

Here is a preview of the page in portuguese

mariokreitz commented 1 month ago

It’s great to hear that you’ve managed to swap the Angular ternary interpolations for dictionaries to support multiple languages. This approach should streamline the translation process.

mariokreitz commented 1 month ago

The changes to the language selector (from switch to a select tag) sound like a good plan. Let me know if you need help checking if the PokeAPI supports Portuguese or if there are any other blockers in the process.

ferracioli commented 1 month ago

Oh, bad news from the future: I couldn't use a portuguese version of the data(nor Portuguese from Portugal). Checking directly the API, I discovered it has considerable lesser amount of information: https://pokeapi.co/api/v2/language/13 Due to this problem, I chose to follow with the spanish translation(it is different from portuguese, but from personal experience, native speakers which don't speak english fell more comfortable with spanish). So my decision was to add the portuguese/spanish in addition to the english/german version. Is it ok? The lack of portuguese language was the only obstacle I found so far.

mariokreitz commented 1 month ago

I'm sorry for this, but nevertheless, it's totally fine if you want to add the Spanish translation. I'm glad to hear again from you =) how's it going so far?

ferracioli commented 1 month ago

No worries :) So I will continue with the spanish version. My code is up to 90% from total complete, so until tomorrow I will apply my pull request! In some parts of the code I couldn't use switch case instead of nested ternaries, but I did my best to change everywhere I could :D (this will allow future languages if we manage to get more programmers to the project)

ferracioli commented 1 month ago

Done, I finished the translation and added a pull request :D

I hope in the future we can get more language translations!