search

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS
MIT License
3.48k stars 116 forks source link

Unknown flag "frame" #16

Closed henryruhs closed 6 years ago

henryruhs commented 6 years ago

The frame flag is missing.

May I also suggest to refactor this great project using commander.js as you reinvented the wheel.

Setup

svg-term: 2.0.3 NodeJS: 8.7.0 NPM: 5.6.0 OS: Ubuntu 17.04

Command

svg-term --cast 113643 --out examples/parrot.svg --frame --no-cursor --from=450

Issue

svg-term: remove unknown flags --frame

marionebl commented 6 years ago

This is a documentation issue.

I updated README.md to reflect the retirement of --frame in favor of --window.

svg-term --cast 113643 --out examples/parrot.svg --window --no-cursor --from=450

should do the trick

marionebl commented 6 years ago

Re: commander. Sure I could do that, just have no inclination to invest the required time as long as the current implementation works well enough.

If there crop up fundamental problems with it I'll revisit - thanks!