Errors should be logged to `stderr` and not `stdout`

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS

MIT License

3.48k stars 116 forks source link

Errors should be logged to `stderr` and not `stdout` #20

Closed adius closed 6 years ago

adius commented 6 years ago

https://github.com/marionebl/svg-term-cli/blob/2b27a6d548a1d9673cc7fb865207235c2b8f586e/src/cli.ts#L492-L500

adius commented 6 years ago

And lines 496 and 497 should be reversed.

marionebl commented 6 years ago

Logging to stderr: OK
Reversing log order: No, I chose the order deliberately to have the actionable errors/warning right next to your prompt

adius commented 6 years ago

Have them next to the prompt sounds like a well-meant idea, but I can't think of a single program which has it in this direction. It took me several tries until I fortuitously saw the error messages at the bottom (color not available) and before that I thought: "Stupid program, why do you print the usage string. I read it already and I think I'm using it correctly." 😅

marionebl commented 6 years ago

Different ways for of terminal usage for different people I guess. Printing it both at the top and bottom might be worth exploring?

adius commented 6 years ago

If you're Ok with that, sounds good.