search

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS
MIT License
3.48k stars 116 forks source link

asciicast v2 compatibility #27

Closed ku1ik closed 6 years ago

ku1ik commented 6 years ago

Hey @marionebl ! Great job with this project 👍

I'll be releasing asciinema 2.0 in the coming days, which uses new asciicast v2 file format, and was wondering if anything needs to be implemented to support it in svg-term-cli (I couldn't locate the actual code which reads the asciicast here). There are already many recordings on asciinema.org in v2 format made using develop branch of asciinema.

Let me know if you need any help!

marionebl commented 6 years ago

Hey @sickill, I'll investigate this weekend - can you post links to some v2 casts here? Thanks!

marionebl commented 6 years ago

For reference: The dependency chain for the code that reads the asciicast is:

svg-term-cli > svg-term > load-asciicast

load-asciicast in turn uses asciinema-player/player/asciicast/load.

ku1ik commented 6 years ago

I see, ok, then you should be covered is load supports v2 for a while now 👍

Example v2 recording on asciinema.org: https://asciinema.org/a/1RdOYnYtFebN6Xv7dv3thdBlt

And direct link to its asciicast file: https://asciinema.org/a/1RdOYnYtFebN6Xv7dv3thdBlt.cast

marionebl commented 6 years ago

Works as expected:

Thanks for reaching out 👍