search

mariusz-ostoja-swierczynski / tech-controllers

TECH Controllers integration for Home Assistant
MIT License
97 stars 67 forks source link

Fix valve temperature sensor #42

Open jakublipinski opened 1 year ago

jakublipinski commented 1 year ago

Fixes obtaining the valve temperature sensor by storing the original tile id and overriding the async_update

anarion80 commented 8 months ago

Currently valve temperatures and other values are implemented as valve sensor entity attributes. I'm honestly not sure which way is better. So I will leave it open in case there are more comments @jakublipinski

jakublipinski commented 1 week ago

@anarion80 I believe the entity approach is better in this case and I can work on rebasing my PR. This can work the same way as TileTemperatureBatterySensor which is not an attribute of TileTemperatureSensor but a regular entity.

The entity provides state recording. The values currentTemp and currentTemp are independent from the valve itself and their state should albo be recorded by default.

Let me know if you will accept such PR.

anarion80 commented 1 week ago

Yes, please go ahead.