Closed m1n0s closed 4 years ago
puzrin
commented
6 years ago I don't see any problems. Your issue can be caused by improper encoding and so on - not related to this project. Could you provide a reproducible samples via http://markdown-it.github.io/linkify-it/ ?
m1n0s
commented
6 years ago Sorry, didn't get what do you mean by "improper encoding" in this case.
I've only discovered that error happens in this project code while constructing some RegExps dependent on site location which brokes library relied on you.
puzrin
commented
6 years ago Please, remove everything, not related to this project to leave minimal possible reproducible sample. That will be a good proof, that problem is really related to this package. Could you do that?
The ideal way would be to reproduce problem in http://markdown-it.github.io/linkify-it/.
m1n0s
commented
6 years ago Ok, I'll try. Do you have a CDN version of the library? I can't find it. Because I must add it onto the website to which I haven't access.
puzrin
commented
6 years ago https://unpkg.com/ everything pulished in npm is available on cdn
m1n0s
commented
6 years ago Yeah, I saw this. But you haven't UMD section. It's impossible just add this js file to the browser.
puzrin
commented
6 years ago Ah, ok. You could use node.js then. This package is platform-agnostic. Browser is not mandatory to create sample.
puzrin
commented
4 years ago Close - timed out with no details.
Amethystafyy282
commented
2 years ago puzrin
commented
2 years ago @Amethystafyy282 see https://github.com/markdown-it/linkify-it/issues/15, i think it's the same or very similar to your case. If you have idea how to formalize condition, that will help. Need someone with experience of "asian groop languages" to discuss.
Amethystafyy282
commented
2 years ago @Amethystafyy282 see #15, i think it's the same or very similar to your case. If you have idea how to formalize condition, that will help. Need someone with experience of "asian groop languages" to discuss.
As I can see, the different is those are not unicode characters(except for the link) and some asian languages doesn`t has any spaces between words.
puzrin
commented
2 years ago @Amethystafyy282 you are right. Some languages not use spaces. Problem is, how to define condition without false positives. For example, is it possible to have links with hieroglyphs in real world? How to define border then?
I suggest to continue in #15 if you have ideas. It's still open to collect useful info.
Hi! I used react-linkify which rely on your module. And I faced with a critical error on one of japanise sites. It was real cause of error because bug reproduces only on this website and was totally okay on english ones.
It happens in RegExp construction at https://github.com/markdown-it/linkify-it/blob/3abf523f6605563083e5ee129bd98dfcbb708ae8/index.js#L170
the error itself
please note
Unmatched ')'.I suppose it happen somewhere here https://github.com/markdown-it/linkify-it/blob/3abf523f6605563083e5ee129bd98dfcbb708ae8/lib/re.js#L168
Feel free to contact me if you need additional info.