marklogic / ml-gradle

Gradle plugin for automating everything involving MarkLogic
Other
72 stars 78 forks source link

Throwing error when requested command does not exist #642

Closed rjrudin closed 1 year ago

rjrudin commented 1 year ago

This would only happen on a programming error - in which case we almost certainly want an error because the caller is expecting a command to be executed and that's not being done. Ran into this when I was testing out a PR but I had not yet published ml-app-deployer, and a task was silently failing because the command wasn't found. An error is much better in that scenario.

rjrudin commented 1 year ago

@ryanjdew I did a quick check to make sure this has no impact on DHF - DHF doesn't have any tasks using the "deploy or undeploy a single command" methods. So no impact on DHF, though if DHF were to use those methods at some point, I think it would still want this behavior - i.e. an error instead of a silent failure when a non-existent command is requested.