markmarkoh / datamaps

Customizable SVG map visualizations for the web in a single Javascript file using D3.js
http://datamaps.github.io
MIT License
3.78k stars 1.01k forks source link

Can't clone/build on Windows #243

Open jaredjensen opened 8 years ago

jaredjensen commented 8 years ago

The dist files are 7 months out of date, so I cloned the repo locally and tried running the Grunt build task. Apparently "nul" is a reserved file name in Windows, so nul.json and nul.topo.json didn't clone, and—not surprisingly—the build task failed. To work around it, I renamed the nul*.json files and updated the Grunt task.

Is there a better place to grab the dist files, or are you not intending to keep those updated?

JamiePoole commented 8 years ago

I would like to confirm this as well as add that all Git processes fail on my Windows 10 setup. Git Bash doesn't even "see" nul files -- even with ls -la -- so Git fails with an fatal: unable to stat ../nul.json: No such file or directory

outdoorsguy commented 8 years ago

The two files nul.json and nul.topo.json found in src/js/data are not valid windows filenames.
Here is a reference from Microsoft: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

This means that on Windows, our Jenkins job, or any other tool, for that matter, is unable to delete these files. Not a minor issue for those who have no other option.

sadranyi commented 7 years ago

What is the fix for this

kriszyp commented 7 years ago

We are also suffering from the inability to cleanup our packages due to this problem.

sadranyi commented 7 years ago

Move the folder to a different location with a shorter name possibly a root drive. You should be able yo delete it

On Aug 3, 2017 1:44 PM, "Kris Zyp" notifications@github.com wrote:

We are also suffering from the inability to cleanup our packages due to this problem.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/markmarkoh/datamaps/issues/243#issuecomment-320084751, or mute the thread https://github.com/notifications/unsubscribe-auth/AAid3FmZyh-NMquBOliFIX7GGLOyLLLbks5sUjEWgaJpZM4GhgAi .

crfroehlich commented 7 years ago

That doesn't work. nul is an invalid filename on Windows. The only solution I've come up with is to:

robocopy SomeEmptyFolder node_modules /MIR

This is pretty annoying.

sadranyi commented 7 years ago

yeah agree with you was so frustrating

On 7 August 2017 at 10:50, Christopher Froehlich notifications@github.com wrote:

That doesn't work. nul is an invalid filename on Windows. The only solution I've come up with is to:

robocopy SomeEmptyFolder node_modules /MIR

This is pretty annoying.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/markmarkoh/datamaps/issues/243#issuecomment-320733206, or mute the thread https://github.com/notifications/unsubscribe-auth/AAid3L8sP8GXKEl4MMFk-DkprFHaozVgks5sV06CgaJpZM4GhgAi .

tjfroll commented 7 years ago

Bump. This is regularly interfering with our builds.

thomas-parrish commented 6 years ago

Why is this still an issue in 2018?

NicolasPerego commented 6 years ago

If you only need to del the files, you can do this in cmd prompt :

Del \\?\C:\My\Path\nul.json Del \\?\C:\My\Path\nul.topo.json

thomas-parrish commented 6 years ago

The issue is that every time we need to do a hard reset in git, it bombs because of these files. The bottom line is that these are not legal file names, and should be renamed. It's very simple.

arooly commented 6 years ago

I bought a package with datamaps and I am stuck trying to delete this 2 files. Stop distributing this package with files that are impossible to delete.

thomas-parrish commented 6 years ago

This project is abandoned. Contact the package vendor and let them know they need to transition to a map plugin that is actively supported.

Unfortunately, this is the failure of open source software.

arooly commented 6 years ago

Thank you Thomas.

markmarkoh commented 6 years ago

@arooly I merged a branch that should resolve the windows issue in the latest version 0.5.9.

arooly commented 6 years ago

Thank you markmarkoh I will test it.

jonbonraki commented 6 years ago

@markmarkoh can you merge it into master instead of 0.5.9?