search

markmfredrickson / optmatch

Functions for optimal matching in R
https://markmfredrickson.github.io/optmatch
Other
47 stars 14 forks source link

C code improvement #95

Closed nullsatz closed 9 years ago

nullsatz commented 9 years ago

Since we have adopted Rcpp to help with binary ISM ops, we could update the rest of the C code to use the Rcpp api. This would reduce the raw lines of code, help reduce the meaningless C boilerplate, and improve readability.

I would also like to introduce doxygen comments in the C code even if we are not using it to produce external docs.

benthestatistician commented 9 years ago

Make sense to me. I imagine there may be a performance hit, but if so then it would likely be modest?

In any case, if Mark agrees then I say go for it.

markmfredrickson commented 9 years ago

Sounds good to me.