search

marko-js-archive / marko-loader

DEPRECATED: see https://github.com/marko-js/webpack
MIT License
10 stars 12 forks source link

Webpack 3 / 4 compatibility #21

Closed jesse1983 closed 6 years ago

jesse1983 commented 6 years ago

Webpack 3 already deprecated this.options in the loader context. Webpack 4 removes it now. Loaders should receive all options via this.query.

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

cameronbraid commented 6 years ago

this pr doesn't fix the issue, as this.query is not the same as this.options in webpack3, see https://github.com/marko-js/marko-loader/pull/24 for solution

austinkelleher commented 6 years ago

@jesse1983 Thank for you for the PR. Closing in favor of https://github.com/marko-js/marko-loader/pull/24