Update E2E acquisition_date to be datetime like the other readers

marksgraham / OCT-Converter

Tools for extracting the raw optical coherence tomography (OCT) and fundus data from proprietary file formats.

https://pypi.org/project/oct-converter/

MIT License

193 stars 70 forks source link

Update E2E acquisition_date to be datetime like the other readers #143

Closed sustrev closed 1 month ago

sustrev commented 1 month ago

All of the readers currently store acquisition_date as a datetime; E2E storing this as a string makes things a bit sticky for DICOM conversion. The other option would be to switch all of the readers to store these values as strings and change the DICOM metadata part to expect strings.

marksgraham commented 1 month ago

Makes sense to me!

sustrev commented 1 month ago

(Did you mean to merge instead of close?)

marksgraham commented 1 month ago

ugh sorry, no! merged now