Added vertical switching if height more than weight

markusenglund / react-switch

A draggable toggle-switch component for React. Check out the demo at:

https://react-switch.netlify.com/

MIT License

1.33k stars 101 forks source link

Added vertical switching if height more than weight #92

Open d8corp opened 3 years ago

d8corp commented 3 years ago

Just added correct behavior if height more than weight, it does not change interfaces.

markusenglund commented 3 years ago

Hi,

Your changes look well thought out and the demo works well. However, I'm leaning towards not merging.

A vertical toggle-switch is as far as I know a very rare use-case and adding support for it might not be worth the additional complexity it brings and supporting it forever.

I would be open to merging this if you or someone else can make a convincing argument that a vertical switch is not a niche use-case and in fact something a lot of users of this library want.

d8corp commented 3 years ago

I completely agree with you. The vertical swipe for UI elements is an antipattern. I just look for some new UX, try different things. Just some food for your brain.