Add search bar to "Add uniform/texture"

markusfisch / ShaderEditor

Android app to create GLSL shaders and use them as live wallpaper

https://play.google.com/store/apps/details?id=de.markusfisch.android.shadereditor

MIT License

924 stars 137 forks source link

Add search bar to "Add uniform/texture" #144

Closed Martysh12 closed 1 year ago

Martysh12 commented 1 year ago

I have written some quite frankly shoddy code (you can tell I'm not an Android developer) for searching through uniforms/textures that should fix #143 when merged. Please review it thoroughly and tell me what's wrong!

Ah, the mandatory screenshot:

Also, make sure to squash before merging! Thanks.

markusfisch commented 1 year ago

This is great! Thank you very much! 👍

And sorry for the delay - I wasn't near my computer over the weekend 😉

Your changes look fine to me! I will merge this as it is - but will probably migrate to a SearchView in the Action Bar, as Material Design features this for exaclty that kind of situation.

Martysh12 commented 1 year ago

You can make an issue for the SearchView, maybe I'll work on it later

markusfisch commented 1 year ago

No problem, I've just changed it as I have used this control before in other apps. Thanks again for the work you've done 👍