Open M00NLIG7 opened 1 year ago
Hey, this is great, but I could you please squash the commits into one and apply gofmt.
Of course!
Get Outlook for iOShttps://aka.ms/o0ukef
From: markuskont @.> Sent: Wednesday, March 22, 2023 2:21:19 AM To: markuskont/go-sigma-rule-engine @.> Cc: Christian Magana @.>; Author @.> Subject: Re: [markuskont/go-sigma-rule-engine] Added Author field in Result struct (PR #28)
Hey, this is greab, but I could you please squash the commits into one and apply gofmt.
— Reply to this email directly, view it on GitHubhttps://github.com/markuskont/go-sigma-rule-engine/pull/28#issuecomment-1479185932, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANVKSCV5QIIK3B5DRPU53RDW5LAA7ANCNFSM6AAAAAAVS5VFSY. You are receiving this because you authored the thread.Message ID: @.***>
IIRC, the DRL, at least for the base Sigma repo, requests that the author's name be published for a Sigma rule match. Just a simple two line change but I am using your repo so i figured it should be compliant :+1: .