marler8997 / zigup

Download and manage zig compilers.
MIT No Attribution
790 stars 61 forks source link

Add CI build for aarch64 for all platforms #67

Closed xEgoist closed 2 years ago

xEgoist commented 2 years ago

closes #60

This change introduces the ability to build aarch64 binaries and upload the artifacts. The CI can also be expanded to include other architectures. Sample run: here

Because it's hard to test these builds on Github Action (with the exception of running linux builds under qemu), tests were left to the x86_64 builds.

marler8997 commented 2 years ago

Looks like goto-bus-stop/setup-zig only downloads x86_64 binaries which I think is why the AARCH64 CI's are failing. I'm going to see if I can get that fixed.

xEgoist commented 2 years ago

Looks like goto-bus-stop/setup-zig only downloads x86_64 binaries which I think is why the AARCH64 CI's are failing. I'm going to see if I can get that fixed.

I could be misinterpreting this but I don't think that would be necessary. Github CI doesn't provide any aarch64 hardware runners. So I think downloading the zig's aarch64 binaries through setup-zig would not help as the runners would not be able to run it or run the tests.

So i believe the only option beside switching to a different CI platform is to test on x86_64 builds and only execute zig build on the other platforms [aarch64]

marler8997 commented 2 years ago

I see I was mistakenly thinking github was able to run on arm hardware. I've modified the CI to build all targets on all 3 ci hosts. Each os also uploads their aarch64 variant. I tested the macos one on my m1 laptop and it seems to work.