search

marmelroy / Zip

Swift framework for zipping and unzipping files.
MIT License
2.51k stars 452 forks source link

Xcode 13 RC compile fix #221

Closed nighthawk closed 2 years ago

nighthawk commented 3 years ago

The line free(buffer) doesn't compile in Xcode 13 RC in my local testing, as buffer is an optional. I've added a guard statement for this, and also one for input, just in case.

gongzhang commented 3 years ago

😎 For the impatient.

.package(url: "https://github.com/maparoni/Zip.git", .revisionItem("059e7346082d02de16220cd79df7db18ddeba8c3")),

Note that this error will only occur on mac or macCatalyst targets.

mgadda commented 3 years ago

Came here to submit the same patch. thanks @nighthawk.

traviskirton commented 3 years ago

Also came here to submit a patch

hamza72x commented 3 years ago

😎 For the impatient.

.package(url: "https://github.com/maparoni/Zip.git", .revisionItem("059e7346082d02de16220cd79df7db18ddeba8c3")),

Note that this error will only occur on mac or macCatalyst targets.

how to do that in Podfile? Looks like Podfile doesn't support :revision type something.

pod 'Zip', :git => 'https://github.com/marmelroy/Zip', :revision => '059e7346082d02de16220cd79df7db18ddeba8c3'
pod 'Zip', :git => 'https://github.com/marmelroy/Zip', :commit => '059e7346082d02de16220cd79df7db18ddeba8c3'

None of these work.

gongzhang commented 3 years ago

@hamza72x

You can try this ⬇️

image

https://guides.cocoapods.org/using/the-podfile.html

Use maparoni's fork repo. Not the original repo. 😄

hamza72x commented 3 years ago

@hamza72x

You can try this ⬇️

image

https://guides.cocoapods.org/using/the-podfile.html

Use maparoni's fork repo. Not the original repo. 😄

marmelroy and maparoni looked similar, my bad. I forked maparoni's repo. Thank you.

marmelroy commented 2 years ago

Thanks @nighthawk @hamza72x @CognitiveDisson and @C4Framework and sorry for the delay with getting this fix in. I am looking for additional collaborators to help maintain Zip to prevent such long delays. Please let me know if any of you are interested.