search

marsbard / puppet-alfresco

A puppet build script for Alfresco
MIT License
25 stars 11 forks source link

Miscellaneous updates #107

Closed bhagyas closed 9 years ago

marsbard commented 9 years ago

There is too much stuff in this PR. Reviewing it all is giving me a headache. Please break it down into individual functions. I'm happy to consider including the loftux build but please don't mix it up with all the other stuff. Also, cannot consider removing giflib without being sure that current centos build will still work

marsbard commented 9 years ago

Also, the PRs need to be done against dev-1.1

bhagyas commented 9 years ago

Didn't notice all the minor changes were also included later. Made the pull request for only the first two commits.

Yes, leave this for now. Working on fixing some issues with safe-download for the connectorJ. Will make a PR later.

On Mon, 5 Oct 2015 at 17:45, Martin Cosgrave notifications@github.com wrote:

Also, the PRs need to be done against dev-1.1

— Reply to this email directly or view it on GitHub https://github.com/marsbard/puppet-alfresco/pull/107#issuecomment-145575961 .