search

martijnvanbrummelen / nwipe

nwipe secure disk eraser
GNU General Public License v2.0
801 stars 86 forks source link

logfile requests #280

Closed mdcato closed 3 years ago

mdcato commented 4 years ago

I'd like to make three suggestions for the logfile. These will help in troubleshooting user issues.

  1. Add an entry for the nwipe version, i.e. " info: nwipe 0.29.006", preferably as the first line of the logfile. That bit of info is just as important as system, baseboard, chassis, processor info, especially if the user is running an old version of nwipe and the issue has already been resolved.

  2. Similarly, add the Linux/distribution info such as this from "cat /proc/version" from my Fedora system which can help if an issue is distribution-dependent: " info: Linux version 5.6.16-300.fc32.x86_64 (mockbuild@bkernel03.phx2.fedoraproject.org) (gcc version 10.1.1 20200507 (Red Hat 10.1.1-1) (GCC)) #1 SMP Thu Jun 4 18:08:38 UTC 2020"

  3. As shown in #1, right-justify the " info: ", "notice: ", " error: ", etc so that it's easier to visually scan for specific strings (if not using grep), and as our (old-school) teachers used to say "neatness counts".

PartialVolume commented 4 years ago

I agree with all those suggestions. Are you planning on doing a pull request? In which case I'll assign it to you. If not I can assign it to me.

mdcato commented 4 years ago

I’m still gun-shy from having a PR killed by clang problems for files I didn’t touch, so would prefer you assign it to yourself. That said, I also volunteered to @louib to run clang things on Fedora 32 if he doesn’t want to commit resources to yet-another-distribution.

From: PartialVolume notifications@github.com Sent: Monday, June 15, 2020 13:09 To: martijnvanbrummelen/nwipe nwipe@noreply.github.com Cc: Mike Cato / Hays Technical Services mike@haystech.com; Author author@noreply.github.com Subject: Re: [martijnvanbrummelen/nwipe] logfile requests (#280)

I agree with all those suggestions. Are you planning on doing a pull request? In which case I'll assign it to you. If not I can assign it to me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/martijnvanbrummelen/nwipe/issues/280#issuecomment-644287260, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANGK2PSNCAX3FN4FJ6L4LVTRWZPTJANCNFSM4N6MWBCQ.

PartialVolume commented 4 years ago

No problem, I'll schedule it into v0.29 and assign it to myself. We should releasing 0.29 very soon. I took a bit of a break from nwipe but am planning to get back into it ASAP.

PartialVolume commented 3 years ago

@mdcato This is next on my list, apologies for the delay, I've been too busy in the last couple of months to catch up with nwipe issues, but am working on it now.

PartialVolume commented 3 years ago

Closed by #297