search

martinlindhe / laravel-vue-i18n-generator

Generates a vue-i18n compatible include file from your Laravel translations
MIT License
306 stars 207 forks source link

feat: Add optional UMD style module export #19

Closed dobromir-hristov closed 7 years ago

dobromir-hristov commented 7 years ago

Add ability to export the locales into an UMD styled export object. References issue #18

martinlindhe commented 7 years ago

Hi, this looks good! However, could you please fix the minor nitpicks i mentioned, in order for the tests to pass.

You can verify tests locally by running (from the root folder of this repository):

vendor/phpunit/phpunit/phpunit
dobromir-hristov commented 7 years ago

Fixed those but its still not passing ☹️

martinlindhe commented 7 years ago

There's only some issue with hhvm, the "traditional" php versions are happy. So i'll merge this, thanks for your work!

dobromir-hristov commented 7 years ago

Uhuu 🎆

martinlindhe commented 7 years ago

I went ahead and disabled the hhvm test, as it has acted up before. Also, version 0.1.14 is released, including this PR, which you now can fetch using composer