Closed fandango96 closed 5 months ago
not sure why the build fails only on s390x
Thanks @fandango96 ! Sorry, I don't have much time this week for a detailed review, as I'm travelling. But for s390 the build log shows a unit test failure:
# DEBUG: umockdev-ioctl.vala:904: Aborting client because ioctl tree for /dev/cros_fp is empty
stderr:
ioctl_varlenstruct_init_from_text: ioctl C014EC00: expected data length 67108884, but got 24 bytes from text data
ERROR: libumockdev-preload: Server requested abort on device /dev/cros_fp, exiting
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
s390x is big endian, this smells like reading a 32 bit int the wrong way around?
Thank you @martinpitt, that was it - fixed.
This looks fine, thanks! Do you need this in a new release, or is git main enough for the libfprint MR?
Thanks! git main is enough for the libfprint MR
This looks fine, thanks! Do you need this in a new release, or is git main enough for the libfprint MR?
@martinpitt looks like the CI doesn't need a new release (as it uses main) but we do a version check during runtime and I'll need to update to a version including this change. Are you planning to do a new release soon?
@fandango96 Sure! I just released https://github.com/martinpitt/umockdev/releases/tag/0.18.4 and will upload to Fedora and Debian now.
@fandango96 Sure! I just released https://github.com/martinpitt/umockdev/releases/tag/0.18.4 and will upload to Fedora and Debian now.
Thank you!
This PR adds the
CROS_EC_DEV_IOCXCMD_V2
andCROS_EC_DEV_IOCEVENTMASK_V2
ioctl
s necessary for testing Chromium OS EC devices. My main use-case is to add support for the FPMCU to allow automated testing inlibfprint
.PR showing use of the newly added
ioctl
s here: https://gitlab.freedesktop.org/libfprint/libfprint/-/merge_requests/493