search

martomo / SublimeTextXdebug

Xdebug debugger client for Sublime Text
MIT License
564 stars 89 forks source link

Added host address configuration (default to '', the current value). #175

Closed bwbroersma closed 6 years ago

bwbroersma commented 6 years ago

So users can decide to listen to 127.0.0.1 (localhost) or 0.0.0.0. I did not yet test with ipv6. In my opinion this is a cleaner fix than the PR https://github.com/martomo/SublimeTextXdebug/pull/173 to always listen to 0.0.0.0.

bwbroersma commented 6 years ago

Like discussed by @escalope in https://github.com/martomo/SublimeTextXdebug/pull/173#issuecomment-326554889 :

I would suggest to keep 127.0.0.1 as default value (not just host='', but explicitly host='127.0.0.1'), and also adding comments suggesting to switch it to 0.0.0.0 if the server hosting the php application is not localhost or it is within a virtual machine / docker container. Also to remind reviewing the firewall rules in the later case to allow the communication.

It's probably best to change the default host address to 127.0.0.1 and add some explicit comment about 0.0.0.0 and the security concerns.