Closed Galixte closed 5 years ago
I could merge this. But honestly I can't bother what's happening in these non-en language files. Personally I feel it would be better if these translations are published separately by the authors.
So maybe it is better your french translation stays in your fork? I could refer to your fork in my readme for people who want a french translated version. You could pull then any changes from my repo.
A side note: The copyright year should be the year when published. So when something was first published in 2014 and received updates, it should be a year span, like 2014 - 2019. All files should have the same year(s) for me; I update the year(s) all in one go with search/replace. If there is somewhere different text, this will be missed out.
Hi @marttiphpbb,
ok I will stay in my fork. For your information I maintain more than 250 translations in French so I assume my part of job.
Sorry for the year in copyright it’s the first time that I read this rule.
Hi @marttiphpbb,
I’m sorry but I don’t know why I didn’t notice that in my previous message: If you don’t want to maintain the translations, I understand. But at least remove them, because currently and for example in French, its a mix of english and french (that’s why I made this PR).
So please, add a link to my GitHub repository instead of keeping FRENCH translation out of date: https://github.com/Galixte/phpbb-ext-customcode
Regards.
Ok, good point.
The translations are removed now and a link to your repo is added in version 3.1.0
Thanks a lot, I’ll update the translation for 3.1.0 version.
Hi @eeemarv @marttiphpbb,
could you merge this, please?
Regards.