search

maruohon / enderutilities

A Minecraft mod that adds various (mostly "ender-themed") blocks and items
GNU Lesser General Public License v3.0
27 stars 15 forks source link

Handy Bag creates infinite items when picking up DE loot cores #100

Open kgn001 opened 4 years ago

kgn001 commented 4 years ago

Base information

Issue

When using the Draconic Staff of Power in conjunction with a Ender Utilities Handy Bag, the loot cores are not picked up, and instead constantly provide a stream of items into the bag, infinitely. Not sure if this is an issue with how Loot cores work or with how the bag handles pickup so will be reported to DE dev as well.

maruohon commented 4 years ago

How do you use that thing? When I'm just grabbing that item from the creative inventory and whacking some creepers and cows with it, they just drop the normal vanilla items and XP. How do you get the Loot Cores, and what are they and what are they supposed to do? I need an easy test setup to see what is going wrong.

kgn001 commented 4 years ago

I guess loot cores is kind of a confusing name, I believe they are meant to reduce server lag basically. To get them you have to use the staff of power to mine blocks in an AOE, I believe anything bigger than 1x1 works but it is easier to see when it is on a bigger setting. They will be little black blobs on the ground, and if you look at them just right it should pop up showing what items are inside. When you stand over it you collect the items, without a handy bag set to auto collect you get what you should, but with it you just keep getting it over and over and it never disappears.

From: Matti Ruohonen notifications@github.com Sent: Saturday, May 16, 2020 9:46:17 AM To: maruohon/enderutilities enderutilities@noreply.github.com Cc: kgn001 kgn001@hotmail.ca; Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

How do you use that thing? When I'm just grabbing that item from the creative inventory and whacking some creepers and cows with it, they just drop the normal vanilla items and XP. How do you get the Loot Cores, and what are they and what are they supposed to do? I need an easy test setup to see what is going wrong.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/maruohon/enderutilities/issues/100#issuecomment-629665716, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVY5EVG7WBTBRMJMGQZ6BLRR2YMTANCNFSM4LAQL7YQ.

maruohon commented 4 years ago

It seems to just be automatically adding all the items to my inventory instead of dropping anything in the world... And I don't see anything in the tool config profile for disabling that.

kgn001 commented 4 years ago

Hmm, I do believe there was either an option in the tool profile, or somewhere in the DE GUI, or it might have been in the configs, though I don't recall changing it from default. I know I was able to disable the loot cores after I discovered the bug, so perhaps DE has updated the default values in their config to disable them or enable the items to go straight to your inventory. I'm not near a computer to do any testing of my own currently, but after the weekend I can try to recreate it myself and give a more detailed response so you don't have to waste as much time.

From: Matti Ruohonen notifications@github.com Sent: Saturday, May 16, 2020 10:00:26 AM To: maruohon/enderutilities enderutilities@noreply.github.com Cc: kgn001 kgn001@hotmail.ca; Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

It seems to just be automatically adding all the items to my inventory instead of dropping anything in the world... And I don't see anything in the tool config profile for disabling that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/maruohon/enderutilities/issues/100#issuecomment-629667571, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVY5EW2JDFCJ4UUUVURL7DRR22BVANCNFSM4LAQL7YQ.

maruohon commented 4 years ago

I saw the option to disable the loot cores in the configs, but that option was disabled, so I assume they should be enabled. But the tool just adds the drops directly to mu inventory by default. I don't know if it's some modifier in the tool that I get from the creative inventory, but I have no idea how to easily get it otherwise (never touched DE before).

kgn001 commented 4 years ago

Okay, yeah just don't worry about it for now, whenever I get access to my computer I'll do some more testing and give you more detailed instructions.

From: Matti Ruohonen notifications@github.com Sent: Saturday, May 16, 2020 10:10:07 AM To: maruohon/enderutilities enderutilities@noreply.github.com Cc: kgn001 kgn001@hotmail.ca; Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

I saw the option to disable the loot cores in the configs, but that option was disabled, so I assume they should be enabled. But the tool just adds the drops directly to mu inventory by default. I don't know if it's some modifier in the tool that I get from the creative inventory, but I have no idea how to easily get it otherwise (never touched DE before).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/maruohon/enderutilities/issues/100#issuecomment-629668860, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVY5EXBXCLAPH7EL2BSNETRR23F7ANCNFSM4LAQL7YQ.

maruohon commented 4 years ago

Any word on this? I have a few other bug fixes lined up for 0.7.15, should I go ahead and release that as-is or wait to look into this?

kgn001 commented 4 years ago

So sorry, I completely forgot. I'm heading on now to try and reproduce it

From: Matti Ruohonen notifications@github.com Sent: Sunday, May 31, 2020 2:31:12 PM To: maruohon/enderutilities enderutilities@noreply.github.com Cc: kgn001 kgn001@hotmail.ca; Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

Any word on this? I have a few other bug fixes lined up for 0.7.15, should I go ahead and release that as-is or wait to look into this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/maruohon/enderutilities/issues/100#issuecomment-636525421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVY5ERJ3EXURNO2MLYXLE3RUK5BBANCNFSM4LAQL7YQ.

kgn001 commented 4 years ago

So, I was able to reproduce it, though I did have to have a full player inventory for it to happen. https://imgur.com/EBZCNaP https://imgur.com/GeN6rJl https://imgur.com/Y1oACBt

Make sure the Handy Bag is set to pickup all, I've also attached my Draconic Evolutions and Ender Utilities configs. with the Staff of power make sure you change the Dig AOE to a large size so it will cause the loot cores to drop. the config option to disable loot cores is on Line 201, make sure it is set to false. Let me know if you need anything else. If you can't figure it out right away just release 0.7.15 as is and can figure it out more for the next release. It isn't super high priority as it's possible to disable them easily in the config.

From: kyle nelson kgn001@hotmail.ca Sent: Monday, June 1, 2020 1:23:13 PM To: maruohon/enderutilities reply@reply.github.com; maruohon/enderutilities enderutilities@noreply.github.com Cc: Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

So sorry, I completely forgot. I'm heading on now to try and reproduce it

From: Matti Ruohonen notifications@github.com Sent: Sunday, May 31, 2020 2:31:12 PM To: maruohon/enderutilities enderutilities@noreply.github.com Cc: kgn001 kgn001@hotmail.ca; Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

Any word on this? I have a few other bug fixes lined up for 0.7.15, should I go ahead and release that as-is or wait to look into this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/maruohon/enderutilities/issues/100#issuecomment-636525421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVY5ERJ3EXURNO2MLYXLE3RUK5BBANCNFSM4LAQL7YQ.

maruohon commented 4 years ago

Unfortunately this issue seems to be unfixable from EnU's side. It looks like DE is creating vanilla EntityItem instances for the pickup event, but it does not respect that EntityItem being setDead() or setItem() being called on it to update the contained item stack. And since it seems to use the exact vanilla EntityItem class for the intermediary entities, I can't even check for the class to try to avoid doing anything on the Loot Core entities.

So I think this would need to be fixed on DE's side, by making the Loot Core code respect the changes made to the EntityItems it uses for the pickup event, ie. the entity being set dead or the item stack on it being changed.

kgn001 commented 4 years ago

It has been reported to them as well on the same day, they just haven't gotten to it. Thanks for looking in to it!

From: Matti Ruohonen notifications@github.com Sent: Wednesday, June 10, 2020 7:44:24 AM To: maruohon/enderutilities enderutilities@noreply.github.com Cc: kgn001 kgn001@hotmail.ca; Author author@noreply.github.com Subject: Re: [maruohon/enderutilities] Handy Bag creates infinite items when picking up DE loot cores (#100)

Unfortunately this issue seems to be unfixable from EnU's side. It looks like DE is creating vanilla EntityItem instances for the pickup event, but it does not respect that EntityItem being setDead() or setItem() being called on it to update the contained item stack. And since it seems to use the exact vanilla EntityItem class for the intermediary entities, I can't even check for the class to try to avoid doing anything on the Loot Core entities.

So I think this would need to be fixed on DE's side, by making the Loot Core code respect the changes made to the EntityItems it uses for the pickup event, ie. the entity being set dead or the item stack on it being changed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/maruohon/enderutilities/issues/100#issuecomment-642018740, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVY5EWGJZMJYICR3BGV64LRV6E3RANCNFSM4LAQL7YQ.