search

marvinhagemeister / xhr-mocklet

Mock XMLHttpRequests in both the browser and node
5 stars 1 forks source link

Add .vscode to .npmignore #18

Closed maoberlehner closed 6 years ago

maoberlehner commented 6 years ago

You absolutely should add your .vscode directory to .npmignore. I've just opened the npm package for debugging and (I think) because I also use the Settings Sync plugin, now all of my settings are the same as yours (globally, not only in the packages directory) -.-

Btw. you should also delete your GitHub Token for the Gist – if you upload it to npm it is not secret anymore ;)

marvinhagemeister commented 6 years ago

Thanks for your report. It's true that the .vscode folder doesn't have to be included in the npm package. Would be great if you could file a bug over at the repo for Settings Sync Plugin because that seems like a bug on there end.

Great find regarding the gist token (read not github). Luckily it didn't contain anything sensitive at all. Thanks for the heads up 🎉