maserlib / ExPRES

Exoplanetary and Planetary Radio Emission Simulator
MIT License
4 stars 3 forks source link

UWS: Retrieve the .sav file #38

Open CorentinLouis opened 3 years ago

CorentinLouis commented 3 years ago

UWS : add the possibility to retrieve a .sav file.

aicardi-obspm commented 3 years ago

Do you mean a precompiled IDL sav file ? It's possible but will it work without tweaking some paths ?

CorentinLouis commented 3 years ago

We already have the possibility with ExPRES (with an option in the json input file) to produce a sav file. The idea will be to retrieve this .sav file in the UVW outputs

aicardi-obspm commented 3 years ago

OK, it should be easy then. Do you expect a specific mime-type for the sav file ? I will use application/octet-stream by default.

aicardi-obspm commented 3 years ago

It's done for the job ExPRES-dev.

CorentinLouis commented 3 years ago

I'm sorry, I realise that I must not have been clear in my request. In ExPRES simulations, you can produce an output .sav file that contains similar information to what is in the cdf. We would like to be able to add to UWS the ability to retrieve this .sav file.

aicardi-obspm commented 3 years ago

Yes that is what I have understood. In your latest runs, you can fetch a file 'SERPE.sav'. I think that this one is produced by the command '@serpe_compile'. I just removed this file from the outputs.

Do you know where your .sav is meant to be saved ? In the same directory as the cdf file ?

BaptisteCecconi commented 3 years ago

for the MIME-type, application/octet-stream is fine.

CorentinLouis commented 3 years ago

Yes that is what I have understood. In your latest runs, you can fetch a file 'SERPE.sav'. I think that this one is produced by the command '@serpe_compile'. I just removed this file from the outputs.

I forgot about this SERPE.sav file. It's also useful to have this file as an output, yes!

Do you know where your .sav is meant to be saved ? In the same directory as the cdf file ?

Yes, in the same directory as the cdf file.

CorentinLouis commented 3 years ago

I just tried to run a simulation with the correct entry to ask ExPRES to produce the sav file (containing the same infos than the CDF), and it worked. Thanks @aicardi-obspm.

@BaptisteCecconi : Do we want to also give the SERPE.sav (produced by the "@serpe_compile" command) file as an output?

aicardi-obspm commented 3 years ago

I didn't understand where the sav file was created in your jobs from yesterday. They were just not created! I'm happy if the current setting suits you.

I wait for Baptiste's answer for the SERPE.sav file before closing the issue.

CorentinLouis commented 2 years ago

@BaptisteCecconi, can you give us your thought on having or not the SERPE.sav file as an output? This file contains all the procedures and functions used for the simulation.

BaptisteCecconi commented 2 years ago

For the ExPRES-dev job, yes, that would be good too.