fix: mark 'should' and 'zombie' as devDependencies

mashpie / i18n-node

Lightweight simple translation module for node.js / express.js with dynamic json storage. Uses common __('...') syntax in app and templates.

MIT License

3.09k stars 421 forks source link

fix: mark 'should' and 'zombie' as devDependencies #446

Closed DRoet closed 4 years ago

DRoet commented 4 years ago

I noticed a lot more dependencies were being pulled in after upgrading to version 0.13.x. Since should and zombie are only being used in development we should probably mark them as devDependencies

coveralls commented 4 years ago

Coverage remained the same at 97.966% when pulling 5b6444f02843c34d464975bda3a31604dd4cd1a8 on DRoet:master into f2145abdb26385298a3ef8d83cc2e97520c1f7ce on mashpie:master.

mashpie commented 4 years ago

true... how could I miss this. Your package lock is resolving vulnerable lodash... anyway I'll fix that

mashpie commented 4 years ago

...and published

DRoet commented 4 years ago

thanks!