Add logging and some CLI args

redzic commented 3 years ago

Changes:

Some checking of input file (if it even exists, the format, so you can't for example input a .png file)
Fancier, configurable (through CLI argument) logging with the log and simplelog crates
More precise bitrate, e.g. store bitrate at 96,000 and pass it to ffmpeg as 96,000 and do calculations with that level of precision, instead of initial bitrate being 96 and passing to ffmpeg as 96K
Extra CLI options, -l/--log to set log level, -m/--model to set location of model that is passed to visqol, and --keep, which keeps the temporary folder (otherwise it deletes it at the end)
Some debug logging, if -l DEBUG is passed then some extra logging happens (specifically of the output of visqol, at least right now)
Other small changes

master-of-zen commented 3 years ago

I pushed embedded visqol model :(, resolving

master-of-zen commented 3 years ago

Resolved, thanks @redzic :+1:

redzic commented 3 years ago

Cool! I think I'm gonna open another PR to make the --model flag optional, and if it isn't provided, then it just uses the default (embedded) model. Also, I don't think it actually uses the embedded model right now, since it passes model.to_str().unwrap() to visqol, which is the CLI option.

master-of-zen commented 3 years ago

Yep, I just resolved, --model must be optional

master-of-zen / BOPUS

Add logging and some CLI args #6