matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
964 stars 79 forks source link

Input character not deleted #200

Open pikeas opened 5 years ago

pikeas commented 5 years ago

Current Behavior This is the inverse of https://github.com/matchai/spacefish/issues/179.

The smallest reproducible case I've found so far is to:

Notice that the "g" remains displayed on screen but is not actually present in the buffer.

Expected Behavior The first input character should not be displayed when deleted.

Relevant Fish Configuration

set SPACEFISH_PROMPT_ORDER user dir host git package docker aws venv conda kubecontext exec_time battery vi_mode jobs char
set SPACEFISH_PROMPT_ADD_NEWLINE true

set -g fish_emoji_width 2

Environment

Additional context/Screenshots

matchai commented 5 years ago

Hmm... My first thought as well was the strangeness that happens around emojis and fish. It looks like you covered your bases and made sure fish and iTerm play nicely with double-width emoji. 🤔

Could you please try using a terminal emulator like Hyper to reproduce the issue? That way we might be able to confirm that this issue is tied to iTerm.

pikeas commented 5 years ago

The issue is reproducible in Hyper, including the rendering bug for the cloud emoji when pasted.